exclude tuple-like types from OnceAction forwarding constructors #4818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3947
Problem
OnceAction
has templated forwarding constructors constrained for callable types.std::tuple<OnceAction>
can incorrectly satisfy those constraints because of how that libc++ implementsstd::tuple
converting constructors.OnceAction
should ever allow a tuple to be treated as a callable.Solution
OnceAction
forwarding constructors to exclude tuple-like types.