-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix drive cmdline-sample #14
base: master
Are you sure you want to change the base?
Conversation
Adapt sample following the dependencies update
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
@kevinthecheung, @rmistry, @mattwhisenhunt how can we proceed to review the pull request? |
|
@ihommani Thank you very much for this pull request , just in time i needed it 🥇 |
|
@ihommani Thanks for fixing the issue. |
devrj8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the changes, It is working. I'm approving these changes.
|
Why aren't these merged? |
|
These really should be merged. Spent 6 hours thinking something was wrong with outdated dependencies/imports until I realized this pull was sitting here. |
|
Merge it brrrrrroooooossssssss |
|
@kurtisvg Can you merge this PR? |
Adapt sample following the dependencies update