Skip to content
This repository was archived by the owner on May 29, 2023. It is now read-only.

Conversation

@robinst
Copy link
Contributor

@robinst robinst commented May 2, 2017

The code used to delegate parsing of escapes in character classes to the
regex crate. That meant that things that work outside of character
classes such as \< or \e would not work inside them.

To fix this, change it to parse the escapes ourselves and then map the
result.

The code used to delegate parsing of escapes in character classes to the
regex crate. That meant that things that work outside of character
classes such as `\<` or `\e` would not work inside them.

To fix this, change it to parse the escapes ourselves and then map the
result.
@robinst
Copy link
Contributor Author

robinst commented May 2, 2017

Note that something like [\H] won't work even with this change, because it requires nested character classes, which are not yet supported in regex. The following pull request adds them, but it's not merged yet: rust-lang/regex#346

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants