Skip to content

Conversation

pguerra-ce
Copy link

Fixes #2789

Summary

Forward state_delta from the FastAPI /run request to Runner.run_async(...), aligning behavior with the documented
API and the /run_sse endpoint.

Why

The documentation for /run explicitly includes:

state_delta (object, optional): A delta of the state to apply before the run.

However, the non‑SSE /run handler did not pass this value through, so Runner.run_async always received None. The
/run_sse path already forwarded it correctly.

Changes

  • src/google/adk/cli/adk_web_server.py
    • Add state_delta=req.state_delta to the "/run" handler’s runner.run_async(...) call.
  • tests/unittests/cli/test_fast_api.py
    • Add test_agent_run_passes_state_delta to test the fix.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @pguerra-ce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a functional discrepancy in the FastAPI /run endpoint, ensuring that the state_delta parameter is correctly processed and forwarded. This change brings the endpoint's behavior into alignment with its specified API documentation and the existing /run_sse endpoint, improving consistency and reliability.

Highlights

  • API Consistency: The /run FastAPI endpoint now correctly passes the state_delta parameter to Runner.run_async, resolving an inconsistency with its documented behavior and the /run_sse endpoint.
  • Bug Fix: Addresses a bug where the state_delta value from the /run request was not being forwarded, always resulting in None for Runner.run_async.
  • Test Coverage: A new unit test, test_agent_run_passes_state_delta, has been added to ensure the state_delta is properly handled and passed through the /run endpoint.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added bot triaged [Bot] This issue is triaged by ADK bot web [Component] This issue will be transferred to adk-web labels Aug 29, 2025
@adk-bot adk-bot requested a review from wyf7107 August 29, 2025 16:57
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly forwards the state_delta from the /run endpoint to the runner, aligning it with the /run_sse endpoint and the API documentation. The added test test_agent_run_passes_state_delta effectively verifies this fix. However, there is a critical issue that will break existing tests. The mock function dummy_run_async in tests/unittests/cli/test_fast_api.py, used by test_agent_run, is not updated to accept the new state_delta argument. Please update its signature to include state_delta=None to prevent a TypeError during testing.

@pguerra-ce pguerra-ce force-pushed the fix-state-delta-missing-in-run branch from 06b6e76 to e583195 Compare August 29, 2025 18:02
@pguerra-ce pguerra-ce force-pushed the fix-state-delta-missing-in-run branch from e583195 to 88950d7 Compare September 1, 2025 14:35
@pguerra-ce pguerra-ce force-pushed the fix-state-delta-missing-in-run branch from 88950d7 to 49cc800 Compare September 1, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot triaged [Bot] This issue is triaged by ADK bot web [Component] This issue will be transferred to adk-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastAPI /run endpoint doesn’t forward state_delta to Runner.run_async
3 participants