-
Notifications
You must be signed in to change notification settings - Fork 119
feat(tools): enforce built-in tools limitations at build/start with h… #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(tools): enforce built-in tools limitations at build/start with h… #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @WastingTimeToThink, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces robust validation for "built-in tools" within the adk
framework, ensuring that LlmAgent
configurations adhere to specific usage constraints. The changes prevent invalid tool setups by enforcing rules at build time, providing clear and helpful error messages to guide developers. This enhances the stability and predictability of agent behavior by catching configuration issues early.
Highlights
- New Built-in Tool Definition: A new marker interface, BuiltInTool, has been introduced to explicitly designate tools that have special framework-level constraints, allowing for their distinct identification and validation.
- Tool Constraint Validation Logic: A new utility class, ToolConstraints, has been added to enforce specific rules for built-in tools. These rules include allowing only one built-in tool per agent (and disallowing mixing with other tool types) and prohibiting built-in tools within sub-agents.
- Build-time Enforcement: The validation logic from ToolConstraints is now hooked into the LlmAgent.Builder#build() method. This ensures that any violations of built-in tool usage rules are caught early at build or startup time, preventing invalid agent configurations from being created.
- Comprehensive Unit Tests: Comprehensive unit tests have been added for the ToolConstraints class, covering various valid and invalid scenarios. These tests ensure the robustness and correctness of the new validation rules, providing confidence in the enforcement mechanism.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces helpful build-time validation for built-in tool usage, preventing incorrect configurations. The implementation is well-structured, using a dedicated ToolConstraints
class and a BuiltInTool
marker interface. The use of MethodHandles
for compatibility is a smart way to ensure loose coupling. The unit tests effectively cover the new validation rules. I've included a few suggestions to enhance code clarity and remove minor redundancies.
core/src/main/java/com/google/adk/tools/internal/ToolConstraints.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/adk/tools/internal/ToolConstraints.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/adk/tools/internal/ToolConstraints.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/adk/tools/internal/ToolConstraints.java
Outdated
Show resolved
Hide resolved
Enforce Built-in tools limitations (Java): early guardrails + helpful error messagesSummaryAdd BuiltInTool marker interface. DetailsIntroduce tools/internal/ToolConstraints to validate the full agent tree. TestsAdded ToolConstraintsTest to cover key scenarios: Backward compatibilityNo changes for valid setups. DocsReuses existing Built-in tools documentation; no new docs added. |
…elpful errors - Add BuiltInTool marker interface. - Add ToolConstraints to validate agent tree: (A1) only one built-in tool per agent; cannot mix with others (A2) built-ins forbidden in sub-agents - Hook validation at LlmAgent.Builder#build() - Unit tests for 5 scenarios; helpful error messages with docs link.
…ts.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ts.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ts.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ts.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
aa5ef7e
to
18dc8ad
Compare
…elpful errors