-
Notifications
You must be signed in to change notification settings - Fork 117
feat: Illustrate simple 1 line main() in CityTimeWeather tutorial #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the execution of the CityTimeWeather tutorial by integrating the web server startup directly into the tutorial's main class. This change allows the tutorial to be run as a standalone application, simplifying its setup and execution process for users.
Highlights
- Simplified Tutorial Execution: The
CityTimeWeather
tutorial can now be run directly as a standalone application by executing itsmain
method, eliminating the need to specify a separate web server class. - pom.xml Configuration Update: The
pom.xml
file for thecity-time-weather
tutorial has been updated to reflect the new main class, pointing tocom.google.adk.tutorials.CityTimeWeather
for execution. - New
main
Method: Apublic static void main(String[] args)
method has been added to theCityTimeWeather
class, which initializes and starts theAdkWebServer
with theROOT_AGENT
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully simplifies the entry point for the CityTimeWeather tutorial by adding a main
method to the CityTimeWeather
class and updating the pom.xml
to use it. The changes are straightforward and achieve the intended goal. I have one suggestion to improve code readability.
tutorials/city-time-weather/src/main/java/com/google/adk/tutorials/CityTimeWeather.java
Outdated
Show resolved
Hide resolved
fc923a2
to
a818100
Compare
Following up to and now applying #372 to #371.