Skip to content

Conversation

@Zxilly
Copy link
Contributor

@Zxilly Zxilly commented May 30, 2024

Some linters won't provider column value for issue, under this situation we should set it to 1.

image

For real world error see https://github.com/Zxilly/go-size-analyzer/actions/runs/9300840788/job/25597744381

@ldez ldez added the area: output Related to issue output label May 30, 2024
@ldez ldez changed the title fix: sarif format require issue column >= 1 fix: SARIF format require issue column >= 1 May 30, 2024
@ldez ldez added the bug Something isn't working label May 30, 2024
@ldez ldez added this to the next milestone May 30, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit e1a8055 into golangci:master May 30, 2024
@ldez ldez modified the milestones: next, v1.59 Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: output Related to issue output bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants