whitespace: update after moving to the analysis package
#4003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
the
linter: update
bombsimon
commented
Aug 10, 2023
bombsimon
force-pushed
the
update-whitespace
branch
2 times, most recently
from
1f3d6c8 to
9ab7274
Compare
bombsimon
force-pushed
the
update-whitespace
branch
from
9ab7274 to
e88f182
Compare
bombsimon
force-pushed
the
update-whitespace
branch
from
e88f182 to
c2ca764
Compare
bombsimon
commented
Nov 2, 2023
Comment on lines
+73
to
+74
| func notGoFmted() { | ||
| fmt.Println("Hello world") |
Member
Author
There was a problem hiding this comment.
Noticed here that we have the same situation as in #4003 (comment). Basically this results in the standalone linter and golangci-lint not fixing the same way, golangci-lint will leave the sapces before fmt whereas the linter itself will replace it with a tab.
I don't think there's anything we should do extra in this specific linter for this scenario (and also that's the same behaviour as before, we just didn't have a standalone linter) but yet another reason to try to integrate the suggested fixes with the golangci-lint fixer.
bombsimon
changed the title
whitespace linter using the analysis packagewhitespace after moving to the analysis package
ldez
changed the title
whitespace after moving to the analysis packageanalysis package
The `whitespace` linter is rewritten to use `annalysis.Analyzer`. This PR will make use of the new code.
bombsimon
force-pushed
the
update-whitespace
branch
from
2850c9d to
57794a9
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
whitespacelinter is rewritten to useannalysis.Analyzer. This PR will make use of the new code.This is a draft PR until ultraware/whitespace#8 is merged and a new release has been made.