dev: fix CI workflow for Windows #3134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/ci-windows-02
branch
from
3451228 to
7f342cd
Compare
This was referenced Aug 24, 2022
Closed
ldez
force-pushed
the
feat/ci-windows-02
branch
from
9f0c8b6 to
61c900a
Compare
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the migration from Travis (Linux and macOS only) to GitHub Actions a job for Windows has been introduced.
continue-on-error: truehas been added in the CI migration PR.So our CI workflow has never worked with Windows.
After a lot of runs on a CI (because I use Linux), and thanks to my previous test framework rewrite, I finally got this job to work.
There are still a few tests that are skipped but these are just a few specific tests.
The side effect: a job on Linux or Darwin takes 4m but 10m on Windows...
Fixes #1382
Previous tries: