Skip to content

Remove comparison to gometalinter in benchmarks #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 21, 2021
Merged

Remove comparison to gometalinter in benchmarks #1732

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9db5019
Remove interfacer linter
pkuca Feb 13, 2021
53581ad
Remove interfacer replace pattern
pkuca Feb 13, 2021
ff04a25
Remove interfacer nolint comments
pkuca Feb 13, 2021
cec8ac0
Remove interfacer linter config
pkuca Feb 13, 2021
cb094ef
Remove InterfacerCheck
pkuca Feb 13, 2021
4969966
Update bench to run golangci-lint only
pkuca Feb 13, 2021
903844f
Run go mod tidy
pkuca Feb 13, 2021
872931a
Remove interfacer from .golangci.yml
pkuca Feb 13, 2021
51cfe62
Merge branch 'master' into remove-interfacer
pkuca Feb 21, 2021
1d3f6dd
Reconcile go.mod after merge
pkuca Feb 21, 2021
e40130c
Restore interfacer nolint directives
pkuca Feb 21, 2021
96b99cd
Restore interfacer replace pattern
pkuca Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 8 additions & 48 deletions test/bench/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
gops "github.com/mitchellh/go-ps"
"github.com/shirou/gopsutil/v3/process"

"github.com/golangci/golangci-lint/pkg/config"
"github.com/golangci/golangci-lint/test/testshared"
)

Expand All @@ -36,7 +35,7 @@ func prepareGithubProject(owner, name string) func(*testing.B) {
_, err := os.Stat(dir)
if os.IsNotExist(err) {
repo := fmt.Sprintf("https://github.com/%s/%s.git", owner, name)
err = exec.Command("git", "clone", repo).Run()
err = exec.Command("git", "clone", repo, dir).Run()
if err != nil {
b.Fatalf("can't git clone %s/%s: %s", owner, name, err)
}
Expand All @@ -56,7 +55,6 @@ func getBenchLintersArgsNoMegacheck() []string {
"--enable=errcheck",
"--enable=dupl",
"--enable=ineffassign",
"--enable=interfacer",
"--enable=unconvert",
"--enable=goconst",
"--enable=gosec",
Expand All @@ -69,21 +67,6 @@ func getBenchLintersArgs() []string {
}, getBenchLintersArgsNoMegacheck()...)
}

func getGometalinterCommonArgs() []string {
return []string{
"--deadline=30m",
"--skip=testdata",
"--skip=builtin",
"--vendor",
"--cyclo-over=30",
"--dupl-threshold=150",
"--exclude", fmt.Sprintf("(%s)", strings.Join(config.GetDefaultExcludePatternsStrings(), "|")),
"--disable-all",
"--enable=vet",
"--enable=vetshadow",
}
}

func printCommand(cmd string, args ...string) {
if os.Getenv("PRINT_CMD") != "1" {
return
Expand All @@ -96,16 +79,6 @@ func printCommand(cmd string, args ...string) {
log.Printf("%s %s", cmd, strings.Join(quotedArgs, " "))
}

func runGometalinter(b *testing.B) {
args := []string{}
args = append(args, getGometalinterCommonArgs()...)
args = append(args, getBenchLintersArgs()...)
args = append(args, "./...")

printCommand("gometalinter", args...)
_ = exec.Command("gometalinter", args...).Run()
}

func getGolangciLintCommonArgs() []string {
return []string{"run", "--no-config", "--issues-exit-code=0", "--deadline=30m", "--disable-all", "--enable=govet"}
}
Expand Down Expand Up @@ -211,20 +184,6 @@ type runResult struct {
duration time.Duration
}

func compare(b *testing.B, gometalinterRun, golangciLintRun func(*testing.B), repoName, mode string, kLOC int) {
gometalinterRes := runOne(b, gometalinterRun, "gometalinter")
golangciLintRes := runOne(b, golangciLintRun, "golangci-lint")

if mode != "" {
mode = " " + mode
}
log.Printf("%s (%d kLoC): golangci-lint%s: time: %s, %.1f times faster; memory: %dMB, %.1f times less",
repoName, kLOC, mode,
golangciLintRes.duration, gometalinterRes.duration.Seconds()/golangciLintRes.duration.Seconds(),
golangciLintRes.peakMemMB, float64(gometalinterRes.peakMemMB)/float64(golangciLintRes.peakMemMB),
)
}

func runOne(b *testing.B, run func(*testing.B), progName string) *runResult {
doneCh := make(chan struct{})
peakMemCh := trackPeakMemoryUsage(b, doneCh, progName)
Expand All @@ -240,7 +199,7 @@ func runOne(b *testing.B, run func(*testing.B), progName string) *runResult {
}
}

func BenchmarkWithGometalinter(b *testing.B) {
func BenchmarkGolangciLint(b *testing.B) {
testshared.NewLintRunner(b).Install()

type bcase struct {
Expand All @@ -252,10 +211,6 @@ func BenchmarkWithGometalinter(b *testing.B) {
name: "self repo",
prepare: prepareGithubProject("golangci", "golangci-lint"),
},
{
name: "gometalinter repo",
prepare: prepareGithubProject("alecthomas", "gometalinter"),
},
{
name: "hugo",
prepare: prepareGithubProject("gohugoio", "hugo"),
Expand Down Expand Up @@ -284,7 +239,12 @@ func BenchmarkWithGometalinter(b *testing.B) {
for _, bc := range bcases {
bc.prepare(b)
lc := getGoLinesTotalCount(b)
result := runOne(b, runGolangciLintForBench, "golangci-lint")

compare(b, runGometalinter, runGolangciLintForBench, bc.name, "", lc/1000)
log.Printf("%s (%d kLoC): time: %s, memory: %dMB",
bc.name, lc/1000,
result.duration,
result.peakMemMB,
)
}
}