confusing error message "File is not goimports-ed (goimports)"

[briantkennedy]

A file not being "goimports-ed" is a little confusing. Can we adjust this error message to something a little clearer like "File has not been formatted (goimports)"

[jirfag]

hi!
it's the good idea, but
now it's too late to change it: some users have already added this text to exclude list.

[pjvds]

now it's too late to change it: some users have already added this text to exclude list.

This way we can never improve error message 😇

[jirfag]

You are right, I got an idea to mark it as v2: in the next version (not in the roadmap yet) we can break compatibility and implement id.

[qfel]

Is this using some custom version of goimports? I recently had it complain about one import even though the file was formatted by goimports. Turned out it wanted me to move it to another group of imports (even though regular goimports doesn't move imports between groups).

[daenney]

This has started to happen to me since 1.24+. Running GolangCI with goimports suggests files aren't properly formatted even though running both gofmt and goimports manually on the files golangci complains about results in no changes and both tools exiting with a status code of 0.

[pierrre]

Same here (but I'm a new user).
It complains for imports containing the - character, such as:

• github.com/opentracing/opentracing-go
• github.com/getsentry/raven-go
• github.com/michaelklishin/rabbit-hole
• github.com/oschwald/geoip2-golang

[jirfag]

@qfel @daenney @pierrre do you use updated goimports? Did you run go get -u golang.org/x/tools/cmd/goimports?

also, let's continue in #347,
this issue about message text

[bcomnes]

I just ran into this problem too. A better message would have gotten me to a fix quicker.

[detailyang]

+1; Human readable message is expected and "File is not goimportes-ed" confused me

[vtopc]

1. What message do you want to see? Please, run goimports tool for this file?
2. Have you tried --fix option?

[bcomnes]

The message should explain what the problem is (e.g. missing an import statement for package x.) It could also maybe propose a solution like, add the import statement or run goimports to add missing import statements. It should not just print what the solution is, because it may not be clear what the problem is for those unfamiliar with the suggested tool.