x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

2025-03-03 14:37 x_tools-gotip-freebsd-amd64-race tools@0efa5e51 go@0312e31e x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes

[adonovan]

Dup of #71817 (types.CheckExpr mutates objects => data race)

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

2025-03-03 20:04 x_tools-go1.23-linux-arm64-race tools@0ffdb82e release-branch.go1.23@e4772831 x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00f47e52a by goroutine 6132:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-arm64/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (22.34s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

2025-03-04 19:48 x_tools-gotip-linux-arm64-race tools@d81d6fcc go@0cfc6414 x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c01597816a by goroutine 4748:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x4c8
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0x94
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2229727998/gopls/internal/cache/analysis.go:906 +0xbc
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (12.07s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

2025-03-05 16:17 x_tools-go1.24-linux-arm64-race tools@07219402 release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00bdbe52a by goroutine 5022:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4111022109/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4111022109/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (16.57s)

2025-03-05 16:17 x_tools-gotip-linux-arm64-race tools@07219402 go@2c160414 x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0137aa6a8 by goroutine 6005:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x520
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1360793670/gopls/internal/cache/analysis.go:605 +0x1dc
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1360793670/gopls/internal/cache/analysis.go:341 +0x430
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x70
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (17.85s)

2025-03-05 16:17 x_tools-gotip-linux-amd64-race tools@340f21a4 go@2c160414 x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00e12596a by goroutine 5100:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2106427111/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2106427111/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x86
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (22.91s)

2025-03-05 16:48 x_tools-go1.24-windows-amd64-race tools@ece9e9ba release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\goroot\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\goroot\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c017b94708 by goroutine 5970:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo2870606075/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo2870606075/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (19.13s)

2025-03-05 18:38 x_tools-go1.24-linux-amd64-longtest-race tools@db6008cb release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log)

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0130f3c08 by goroutine 5506:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3405952524/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3405952524/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/sync@v0.11.0/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (43.00s)

— watchflakes