showreels in lightbox #1146
Open
showreels in lightbox #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
topic:content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
Instead of opening YT showreels in a new tab, we could open them in the (already used) Tobii lightbox.
All functionality included (fullscreen, seek, volume etc). They're grouped and you can switch between them via navigation buttons.
Miserably, the navigation between the group is not working with keyboard arrow keys, because the YT object captures them. Swiping on mobile is not supported either. If you have an idea on how to fix this, please file in https://github.com/midzer/tobii upstream :)
Cheers
midzer