Skip to content

Conversation

@timhuynh94
Copy link
Contributor

@timhuynh94 timhuynh94 commented Apr 7, 2025

Fix int types according to go-vela/server#1260
Contains #633 changes. If this is merged in first, it will superseded PR-633
Depends on go-vela/sdk-go#353 and #633

@timhuynh94 timhuynh94 requested a review from a team as a code owner April 7, 2025 19:36
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 58.33%. Comparing base (96e8f70) to head (4973c75).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/vela-worker/flags.go 0.00% 10 Missing ⚠️
cmd/vela-worker/main.go 0.00% 7 Missing ⚠️
cmd/vela-worker/run.go 0.00% 4 Missing ⚠️
cmd/vela-worker/operate.go 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (58.33%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   62.28%   58.33%   -3.96%     
==========================================
  Files         123      123              
  Lines        8365     8287      -78     
==========================================
- Hits         5210     4834     -376     
- Misses       2915     3251     +336     
+ Partials      240      202      -38     
Files with missing lines Coverage Δ
executor/linux/build.go 75.43% <100.00%> (ø)
runtime/docker/container.go 81.38% <100.00%> (ø)
runtime/kubernetes/container.go 80.23% <100.00%> (ø)
cmd/vela-worker/operate.go 0.00% <0.00%> (ø)
cmd/vela-worker/run.go 0.00% <0.00%> (ø)
cmd/vela-worker/main.go 0.00% <0.00%> (ø)
cmd/vela-worker/flags.go 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, but can we update description and title to talk about urfave upgrade also? i think a majority of the updates in the PR are related to that.

@timhuynh94 timhuynh94 requested a review from wass3rw3rk April 9, 2025 14:57
@timhuynh94 timhuynh94 changed the title fix(int)!: fix int types fix(int)!: fix int types and update to urfave v3 Apr 9, 2025
@timhuynh94 timhuynh94 merged commit 96d569b into main Apr 9, 2025
11 of 14 checks passed
@timhuynh94 timhuynh94 deleted the fix_int_types branch April 9, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants