-
Notifications
You must be signed in to change notification settings - Fork 10
fix(int)!: fix int types and update to urfave v3 #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (58.33%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
- Coverage 62.28% 58.33% -3.96%
==========================================
Files 123 123
Lines 8365 8287 -78
==========================================
- Hits 5210 4834 -376
- Misses 2915 3251 +336
+ Partials 240 202 -38
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me, but can we update description and title to talk about urfave upgrade also? i think a majority of the updates in the PR are related to that.
Fix int types according to go-vela/server#1260
Contains #633 changes. If this is merged in first, it will superseded PR-633
Depends on go-vela/sdk-go#353 and #633