Skip to content

Fix generates problems. #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix generates problems. #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02cb75
Fix generates problems.
trulede Jul 5, 2025
e5b31c1
Update glob.go for linter suggestion.
trulede Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/fingerprint/glob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package fingerprint
import (
"os"
"sort"
"strings"

"github.com/go-task/task/v3/internal/execext"
"github.com/go-task/task/v3/internal/filepathext"
Expand All @@ -25,6 +26,7 @@ func Globs(dir string, globs []*ast.Glob) ([]string, error) {

func glob(dir string, g string) ([]string, error) {
g = filepathext.SmartJoin(dir, g)
g = strings.ReplaceAll(g, " ", `\ `)

fs, err := execext.ExpandFields(g)
if err != nil {
Expand Down
17 changes: 15 additions & 2 deletions internal/fingerprint/sources_timestamp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,21 @@ func (checker *TimestampChecker) IsUpToDate(t *ast.Task) (bool, error) {
if err != nil {
return false, nil
}
generates, err := Globs(t.Dir, t.Generates)
if err != nil {
generates := []string{}
for _, g := range t.Generates {
if g.Negate {
continue // 'excludes' not considered for generates.
}
files, err := glob(t.Dir, g.Glob)
if os.IsNotExist(err) || len(files) == 0 {
return false, nil
}
if err != nil {
return false, err
}
generates = append(generates, files...)
}
if len(generates) == 0 {
return false, nil
}

Expand Down
Loading