Skip to content

Avoid panic in TestRowsColumnTypes #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2023
Merged

Avoid panic in TestRowsColumnTypes #1426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cc9f53
optimized the execution flow of the TestRowsColumnTypes unit test
wayyoungboy May 6, 2023
66a50e4
Update driver_test.go
methane May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion driver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2945,7 +2945,10 @@ func TestRowsColumnTypes(t *testing.T) {
continue
}
}

//Avoid：values is nil
if t.Failed() {
return
}
values := make([]interface{}, len(tt))
for i := range values {
values[i] = reflect.New(types[i]).Interface()
Expand Down