Skip to content

bump actions/checkout@v3 and actions/setup-go@v3 #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2022
Merged

bump actions/checkout@v3 and actions/setup-go@v3 #1375

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0161fde
bump actions/checkout@v3 and actions/setup-go@v3
shogo82148 Nov 29, 2022
185228e
enable cache of actions/setup-go
shogo82148 Nov 29, 2022
d9aac3a
Revert "enable cache of actions/setup-go"
shogo82148 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ jobs:
fail-fast: false
matrix: ${{ fromJSON(needs.list.outputs.matrix) }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
Copy link
Member

@methane methane Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding cache: true here?

Copy link
Contributor Author

@shogo82148 shogo82148 Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Contributor Author

@shogo82148 shogo82148 Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but actions/setup-go fails with Go 1.14 when cache: true is enabled.
https://github.com/go-sql-driver/mysql/actions/runs/3574840133/jobs/6010627696

Copy link
Member

@methane methane Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache option in setup-go uses go.sum file. So we can not use it for now.

- uses: shogo82148/actions-setup-mysql@v1
Expand Down