Skip to content

Forwarding gitlab JobEvents to BuildEvents does not make sense #175

@finkandreas

Description

@finkandreas

return eventParsing(BuildEvents, events, payload)

Forwarding this event as a BuildEvents requires that the user subscribes to both JobEvents and BuildEvents when they call hook.Parse(...).
Otherwise the end up with the error message in
return nil, ErrEventNotFound

This leads to confusing code, when one wants to actually subscribe to JobEvents, but must handle it later on as gitlab.BuildEventPayload.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions