fix parsing prepare response #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
fix-decoding-prepare-response
branch
from
89bc530 to
056c336
Compare
Contributor
Author
|
lint error fixed in #1058 |
Collaborator
|
Thanks. I'll take a look later |
dveeden
approved these changes
Oct 16, 2025
Collaborator
dveeden
left a comment
dveeden
left a comment
There was a problem hiding this comment.
Looks correct when compared with the docs. Haven't tested the code.
What about CLIENT_OPTIONAL_RESULTSET_METADATA? Should there be a comment? A check to ensure it isn't set? or fully implemented?
Contributor
Author
|
Right now we don't support |
https://dev.mysql.com/doc/dev/mysql-server/9.3.0/page_protocol_com_stmt_prepare.html warnings is optional from server, & is preceded by a reserved byte
serprex
force-pushed
the
fix-decoding-prepare-response
branch
from
f691e29 to
0e0e4c7
Compare
lance6716
approved these changes
Oct 17, 2025
Collaborator
|
I think we'd better to check a non-zero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.mysql.com/doc/dev/mysql-server/9.3.0/page_protocol_com_stmt_prepare.html
warnings is optional from server, & is preceded by a reserved byte