This repository was archived by the owner on Jun 8, 2019. It is now read-only.
Functions for releases #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
suggested changes
Dec 28, 2016
Member
bkcsoft
left a comment
bkcsoft
left a comment
There was a problem hiding this comment.
The same for CreateReleaseOption and EditReleaseOption :)
gitea/releases.go
Outdated
| // Release represents a repository release | ||
| type Release struct { | ||
| ID int64 `json:"id"` | ||
| TagName string `json:"string"` |
Member
There was a problem hiding this comment.
this should be json:"tag_name" according to https://developer.github.com/v3/repos/releases/
| IsPrerelease bool `json:"prerelease"` | ||
| Created time.Time `json:"created"` | ||
| Publisher *User `json:"author"` | ||
| } |
Member
There was a problem hiding this comment.
Missing TarBall, ZipBall, all *URL, Name, PublishedAt :)
https://developer.github.com/v3/repos/releases/#response
Member
Author
There was a problem hiding this comment.
I've added url, tarball_url, zipball_url, name, and published_at. I did not add html_url, assets_url, or upload_url, since they don't currently apply to Gitea.
gitea/releases.go
Outdated
| ID int64 `json:"id"` | ||
| TagName string `json:"string"` | ||
| Target string `json:"target_commitish"` | ||
| Title string `json:"title"` |
ethantkoenig
force-pushed
the
releases
branch
from
6799cad to
f672f53
Compare
ethantkoenig
force-pushed
the
releases
branch
from
f672f53 to
90d9b14
Compare
Member
Author
|
@bkcsoft Updated |
Member
|
LGTM |
|
LGTM |
Member
|
@bkcsoft anything missing for you? |
Member
|
No, LGTM |
bkcsoft
approved these changes
Dec 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions for the following endpoints:
GET /repos/:user/:repo/releases: List a repository's releasesGET /repos/:user/:repo/releases/:id: Get a releasePOST /repos/:user/:repo/releases: Create a new releasePATCH /repos/:user/:repo/releases/:id: Edit a releaseDELETE /repos/:user/:repo/releases/:id: Delete a releaseSee also go-gitea/gitea#510