Skip to content

[Docs] add usefull info to REQUIRE_SIGNIN_VIEW #9848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2020
Merged

[Docs] add usefull info to REQUIRE_SIGNIN_VIEW #9848

merged 4 commits into from
Jan 17, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Jan 17, 2020 •
edited
Loading

dont happen #9846 again

and apply suggestion of #9784 (comment)

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jan 17, 2020
techknowlogick
techknowlogick reviewed Jan 17, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2020
@6543
Copy link
Member Author

6543 commented Jan 17, 2020

@techknowlogick done

jolheiser
jolheiser reviewed Jan 17, 2020
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jan 17, 2020 •
edited
Loading

Codecov Report

Merging #9848 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9848      +/-   ##
==========================================
- Coverage   42.31%   42.31%   -0.01%     
==========================================
  Files         604      604              
  Lines       79130    79130              
==========================================
- Hits        33485    33484       -1     
  Misses      41521    41521              
- Partials     4124     4125       +1
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️
services/pull/patch.go 67.92% <0%> (+1.88%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c561903...68aa217. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2020
@6543
Copy link
Member Author

6543 commented Jan 17, 2020 •
edited
Loading

Ready to merge 🚀

@techknowlogick techknowlogick merged commit fec1095 into go-gitea:master Jan 17, 2020
@6543 6543 deleted the docs-REQUIRE_SIGNIN_VIEW branch January 17, 2020 23:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@6543 @codecov-io @techknowlogick @zeripath @jolheiser @GiteaBot