Skip to content

Backport: allow users with explicit read access to give approvals #8398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2019
Merged

Backport: allow users with explicit read access to give approvals #8398

merged 1 commit into from
Oct 6, 2019

Conversation

@guillep2k
Copy link
Member

@guillep2k guillep2k commented Oct 6, 2019

Backport of #8382

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 6, 2019
@lafriks lafriks added this to the 1.9.4 milestone Oct 6, 2019
@guillep2k
Copy link
Member Author

guillep2k commented Oct 6, 2019

Mmm.... is this a temporary error?

go: go.mongodb.org/[email protected]: unrecognized import path "go.mongodb.org/mongo-driver" (https fetch: Get https://go.mongodb.org/mongo-driver?go-get=1: EOF)

@techknowlogick
Copy link
Member

techknowlogick commented Oct 6, 2019

I've just restarted the build.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2019
@techknowlogick techknowlogick merged commit 5bac1a6 into go-gitea:release/v1.9 Oct 6, 2019
@lunny lunny mentioned this pull request Oct 7, 2019
Closed
@guillep2k guillep2k deleted the fix-8297-backport branch October 9, 2019 15:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.9.4

Development

Successfully merging this pull request may close these issues.

4 participants

@guillep2k @techknowlogick @lafriks @GiteaBot