Don't force a password change for the admin user when creating an account via cli #5391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelowo
changed the title
techknowlogick
approved these changes
Nov 23, 2018
bkcsoft
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #5391 +/- ##
==========================================
- Coverage 37.47% 37.45% -0.02%
==========================================
Files 312 312
Lines 46509 46509
==========================================
- Hits 17430 17421 -9
- Misses 26591 26597 +6
- Partials 2488 2491 +3
Continue to review full report at Codecov.
|
lunny
approved these changes
Nov 24, 2018
bkcsoft
added
lgtm/done
lafriks
reviewed
Nov 24, 2018
… (admin) user via the cli. Use flag if present but make sure to default to not forcing a password update
lafriks
approved these changes
Nov 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #5376 (comment) .
If the account being created is the initial admin account, skip requesting a password change.