Skip to content

update image used for build-without-gcc step #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 29, 2018
Merged

update image used for build-without-gcc step #4818

merged 4 commits into from
Aug 29, 2018

Conversation

@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Aug 29, 2018

As we've dropped support for go 1.8 (see 1.5.0 release post for details),
now we need to ensure that a minimum of go 1.9 builds correctly.

@techknowlogick
update image used for build-without-gcc step
ace42a0 
As we've dropped support for go 1.8 (see 1.5.0 release post),
now we need to ensure that a minimum of go 1.9 builds correctly.
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 29, 2018
@techknowlogick techknowlogick added this to the 1.6.0 milestone Aug 29, 2018
@codecov-io
Copy link

codecov-io commented Aug 29, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a938ddf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4818   +/-   ##
=========================================
  Coverage          ?   37.21%           
=========================================
  Files             ?      305           
  Lines             ?    45041           
  Branches          ?        0           
=========================================
  Hits              ?    16761           
  Misses            ?    25843           
  Partials          ?     2437

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a938ddf...ec01092. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2018
@lunny
Copy link
Member

lunny commented Aug 29, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2018
@techknowlogick
Copy link
Member Author

techknowlogick commented Aug 29, 2018

make LG-TM work

@techknowlogick techknowlogick merged commit fcea868 into go-gitea:master Aug 29, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-9 branch August 29, 2018 14:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@techknowlogick @codecov-io @lunny @adelowo @bkcsoft