Skip to content

Provide compressed releases #3991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2018
Merged

Provide compressed releases #3991

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
565addf
Add release-compress to provide compressed releases
sapk May 18, 2018
dc51a0c
check after compress
sapk May 21, 2018
97f86ac
Merge branch 'master' into compress-releases
sapk May 21, 2018
929370a
Merge branch 'master' into compress-releases
techknowlogick May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ $(EXECUTABLE): $(SOURCES)
$(GO) build $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@

.PHONY: release
release: release-dirs release-windows release-linux release-darwin release-copy release-check
release: release-dirs release-windows release-linux release-darwin release-copy release-check release-compress
Copy link
Member

@techknowlogick techknowlogick May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should compress come before check? I think in check the sha256 sums are calculated.

Copy link
Member Author

@sapk sapk May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think of it but it will generate a hash of the compressed version and I wasn't thinking it was usefull.

Copy link
Member Author

@sapk sapk May 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I think of onecase, for example in AUR package the hash is checked when we download so if the package is base on compressed version it will need it.

Copy link
Member Author

@sapk sapk May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change done


.PHONY: release-dirs
release-dirs:
Expand Down Expand Up @@ -274,6 +274,13 @@ release-copy:
release-check:
cd $(DIST)/release; $(foreach file,$(wildcard $(DIST)/release/$(EXECUTABLE)-*),sha256sum $(notdir $(file)) > $(notdir $(file)).sha256;)

.PHONY: release-compress
release-compress:
@hash gxz > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
$(GO) get -u github.com/ulikunitz/xz/cmd/gxz; \
fi
find $(DIST)/release -name "$(EXECUTABLE)-*" -not -name *.sha256 -print0 | xargs -0 gxz -k -9

.PHONY: javascripts
javascripts: public/js/index.js

Expand Down