Skip to content

fix: if Mirrors repo no content is fetched, updated time should not b… #3551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2018
Merged

fix: if Mirrors repo no content is fetched, updated time should not b… #3551

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5a67a1
fix: if Mirrors repo no content is fetched, updated time should not b…
appleboy Feb 21, 2018
07ac201
fix: sync update time from mirror repo.
appleboy Feb 22, 2018
e5e8765
fix: one single session.
appleboy Feb 22, 2018
ac27f46
update comment.
appleboy Feb 22, 2018
9dbd43e
Merge branch 'master' into patch-11
lafriks Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion models/repo_mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ func MirrorUpdate() {
// SyncMirrors checks and syncs mirrors.
// TODO: sync more mirrors at same time.
func SyncMirrors() {
sess := x.NewSession()
defer sess.Close()
// Start listening on new sync requests.
for repoID := range MirrorQueue.Queue() {
log.Trace("SyncMirrors [repo_id: %v]", repoID)
Expand All @@ -260,10 +262,22 @@ func SyncMirrors() {
}

m.ScheduleNextUpdate()
if err = UpdateMirror(m); err != nil {
if err = updateMirror(sess, m); err != nil {
log.Error(4, "UpdateMirror [%s]: %v", repoID, err)
continue
}

Copy link
Member

@lunny lunny Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But line 263 has updated all the columns of the records.

Copy link
Member Author

@appleboy appleboy Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. It only update the NextUpdateUnix value. Right?

Copy link
Member Author

@appleboy appleboy Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we need to update the updated_unix field of repo table.

Copy link
Member

@lunny lunny Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appleboy. No. It should only update NextUpdateUnix maybe I don't know. But in fact it will update all the columns included updated_unix. So that your PR will update the record twice.

Copy link
Member Author

@appleboy appleboy Feb 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny Line 263 just update the mirror table and this PR update updated_unix field on the other table repository

Copy link
Member

@lunny lunny Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes you are right. And maybe you can also refactor there to use one DB connection but not get connection from cache.

Copy link
Member Author

@appleboy appleboy Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny Done. See e5e8765

// Get latest commit date and update to current repository updated time
commitDate, err := git.GetLatestCommitTime(m.Repo.RepoPath())
if err != nil {
log.Error(2, "GetLatestCommitDate [%s]: %v", m.RepoID, err)
continue
}

if _, err = sess.Exec("UPDATE repository SET updated_unix = ? WHERE id = ?", commitDate.Unix(), m.RepoID); err != nil {
log.Error(2, "Update repository 'updated_unix' [%s]: %v", m.RepoID, err)
continue
}
}
}

Expand Down