Refactor commit status for Actions jobs (#23786) #24060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor commit status for Actions jobs (go-gitea#23786) Before: <img width="353" alt="xnip_230329_163852" src="https://user-images.githubusercontent.com/9418365/228479807-424452df-10fa-45cf-ae4b-09939c0ed54c.png"> After: <img width="508" alt="xnip_230329_163358" src="https://user-images.githubusercontent.com/9418365/228479923-537b54fe-9564-4105-a068-bcc75fa2a7ea.png"> Highlights: - Treat `StatusSkipped` as `CommitStatusSuccess` instead of `CommitStatusFailure`, so it fixed go-gitea#23599. - Use the bot user `gitea-actions` instead of the trigger as the creator of commit status. - New format `<run_name> / <job_name> / (<event>)` for the context of commit status to avoid conflicts. - Add descriptions for commit status. - Add the missing calls to `CreateCommitStatus`. - Refactor `CreateCommitStatus` to make it easier to use.
delvh
added
type/bug
type/enhancement
delvh
approved these changes
Apr 11, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Apr 12, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
Member
|
🤖 🎺 |
Member
|
Thanks! And sorry I overlooked this. 😂 |
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23786
Refactor commit status for Actions jobs (#23786)
Before:
After:
Highlights:
StatusSkippedasCommitStatusSuccessinstead ofCommitStatusFailure, so it fixed [actions] Skipped jobs are displayed as failed #23599.gitea-actionsinstead of the trigger as the creator of commit status.<run_name> / <job_name> / (<event>)for the context of commit status to avoid conflicts.CreateCommitStatus.CreateCommitStatusto make it easier to use.