Skip to content

Conversation

@silverwind
Copy link
Member

Updated all tool dependencies to latest tags, hoping CI will like it.

Updated all tool dependencies to latest tags, hoping CI will like it.
@silverwind silverwind added this to the 1.17.0 milestone May 10, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2022
@silverwind
Copy link
Member Author

New lint errors should be handled now.

@silverwind
Copy link
Member Author

silverwind commented May 10, 2022

ed1d95c had disabled the strings.Title check, but it now came back because the error text had changed. Anyways, I resolved it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2022
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @silverwind <3

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2022
@6543 6543 merged commit 318f360 into go-gitea:main May 10, 2022
@silverwind silverwind deleted the tooldeps branch May 10, 2022 22:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 11, 2022
* giteaofficial/main:
  Fix oauth setting list bug (go-gitea#19682)
  Delete user related oauth stuff on user deletion too (go-gitea#19677)
  Move access and repo permission to models/perm/access (go-gitea#19350)
  Tidy up `<head>` template (go-gitea#19678)
  Update go tool dependencies (go-gitea#19676)
  Update JS dependencies (go-gitea#19675)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Update go tool dependencies

Updated all tool dependencies to latest tags, hoping CI will like it.

* fix new lint errors

* handle more strings.Title cases

* remove lint skip
jolheiser pushed a commit that referenced this pull request Apr 3, 2023
Regression of #19676 and #21814

Fix #23872

`cases.Title` is not thread-safe, it has internal state, so it can't be
used as a global shared variable.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 3, 2023
Regression of go-gitea#19676 and go-gitea#21814

Fix go-gitea#23872

`cases.Title` is not thread-safe, it has internal state, so it can't be
used as a global shared variable.
6543 pushed a commit that referenced this pull request Apr 3, 2023
Backport #23885 by @wxiaoguang

Regression of #19676 and #21814

Fix #23872

`cases.Title` is not thread-safe, it has internal state, so it can't be
used as a global shared variable.

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants