Skip to content

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 28, 2021

fixes #18112

It's the same behaviour as if you create a branch: empty commit list but the head commit is the last commit.

I'm not sure about the compare url. With git.EmptySHA you will see a 404 page. GitHub displays a "There isn’t anything to compare" page in this case.

@KN4CK3R KN4CK3R added the type/enhancement An improvement of existing functionality label Dec 28, 2021
@Gusted
Copy link
Contributor

Gusted commented Dec 28, 2021

I'm not sure about the compare url. With git.EmptySHA you will see a 404 page. GitHub displays a "There isn’t anything to compare" page in this case.

Well, that should be a enhancement for another PR as it's in this case a valid URL in that sense.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 29, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@72f9050). Click here to learn what that means.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18116   +/-   ##
=======================================
  Coverage        ?   44.91%           
=======================================
  Files           ?      824           
  Lines           ?    91598           
  Branches        ?        0           
=======================================
  Hits            ?    41144           
  Misses          ?    43859           
  Partials        ?     6595           
Impacted Files Coverage Δ
services/repository/push.go 53.05% <71.42%> (ø)
services/release/release.go 52.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f9050...edd791d. Read the comment docs.

@lunny lunny added this to the 1.16.0 milestone Dec 29, 2021
@lunny lunny merged commit 8fa97a2 into go-gitea:main Dec 29, 2021
@lunny
Copy link
Member

lunny commented Dec 29, 2021

I think it's better to backport this to v1.15

zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Dec 29, 2021
* giteaoffical/main:
  Use conditions but not repo ids as query condition (go-gitea#16839)
  Set HeadCommit when creating tags. (go-gitea#18116)
@KN4CK3R KN4CK3R deleted the fix-18112 branch December 30, 2021 13:01
@lunny
Copy link
Member

lunny commented Jan 4, 2022

Please send backport.

lunny pushed a commit to lunny/gitea that referenced this pull request Jan 4, 2022
@lunny lunny added the backport/done All backports for this PR have been created label Jan 4, 2022
6543 pushed a commit that referenced this pull request Jan 4, 2022
@richmahn richmahn mentioned this pull request Jan 14, 2022
zeripath pushed a commit that referenced this pull request Jan 14, 2022
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (#18260) (#18261)
  * Fix release link broken (#18252) (#18253)
  * Fix update user from site administration page bug (#18250) (#18251)
  * Set HeadCommit when creating tags (#18116) (#18173)
  * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152)
  * Fix purple color in suggested label colors (#18241) (#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)
zeripath pushed a commit to zeripath/gitea that referenced this pull request Jan 14, 2022
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261)
  * Fix release link broken (go-gitea#18252) (go-gitea#18253)
  * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251)
  * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173)
  * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152)
  * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)
techknowlogick pushed a commit that referenced this pull request Jan 14, 2022
* Changelog for 1.15.10 (#18274)

[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (#18260) (#18261)
  * Fix release link broken (#18252) (#18253)
  * Fix update user from site administration page bug (#18250) (#18251)
  * Set HeadCommit when creating tags (#18116) (#18173)
  * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152)
  * Fix purple color in suggested label colors (#18241) (#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)

* update docs/config.yaml

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Richard Mahn <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Changelog for 1.15.10 (go-gitea#18274)

[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261)
  * Fix release link broken (go-gitea#18252) (go-gitea#18253)
  * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251)
  * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173)
  * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152)
  * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)

* update docs/config.yaml

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Richard Mahn <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tag push creates webhook with empty commits and head_commit

6 participants