Skip to content

Delete protected branch if repository gets removed #15658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2021
Merged

Delete protected branch if repository gets removed #15658

merged 4 commits into from
Apr 29, 2021

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 29, 2021

If a repository gets removed the protected branch does not get removed too.
Added a doctor fix too.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 29, 2021
@6543
Copy link
Member

6543 commented Apr 29, 2021

mariadb Ver 15.1:

[3] Check consistency of database
 - [W] 13 protected branches without existing repository

--fix:

[3] Check consistency of database
 - [C] Error: Unsupported type whilst deleting orphaned objects

@6543
Copy link
Member

6543 commented Apr 29, 2021

ok the detected issue looks like is also in master :/

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2021
@6543
Copy link
Member

6543 commented Apr 29, 2021

🚀

@6543 6543 merged commit 2e85165 into go-gitea:master Apr 29, 2021
@6543 6543 mentioned this pull request Apr 29, 2021
Closed
@6543
Copy link
Member

6543 commented Apr 29, 2021

merged since we need this bugfix, the doctor bug is a other one ...

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 30, 2021

yes, the other bug gets fixed with #15657

KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Apr 30, 2021
@KN4CK3R
Delete protected branch if repository gets removed (go-gitea#15658)
2ecc6e3 
* Added missing error parameters.

* Delete protected branch if repository gets removed.

* Added doctor fix.
@KN4CK3R KN4CK3R mentioned this pull request Apr 30, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Apr 30, 2021
@KN4CK3R KN4CK3R mentioned this pull request Apr 30, 2021
Merged
zeripath pushed a commit that referenced this pull request Apr 30, 2021
@KN4CK3R
Delete protected branch if repository gets removed (#15658) (#15676)
54263ff 
* Added missing error parameters.

* Delete protected branch if repository gets removed.

* Added doctor fix.
@KN4CK3R KN4CK3R deleted the fix-delete-protected-branch branch May 7, 2021 06:30
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KN4CK3R @6543 @lunny @GiteaBot