Make Protected Branches -> Approvals section easier to understand

[worthy7]

Small issue concerning UX design which at least caused me a little bit of confusion.

1. Allow only to merge pull request with enough positive reviews of whitelisted users or teams.
   -> Allow merging of pull requests only with enough positive reviews from approvers.

2. Whitelisted reviewers: -> Reviewers:

3. default text set to Search contributing teams or users...

4. Add a checkbox first saying "Require approvals", when unchecked the two options are disabled, when checked, the "number of approvals" is minimum 1 and the input for Approvers should be "required" (input required). Doing a dynamic calculation to see if they match is not worth it since team sizes can change in the future

For reference here is how GitHub looks

I made a mock-up design for someone to follow:

Open for discussion!

[bagasme]

Please consider also the case when the approvers are writers, as per #8288 (which I open the issue).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[kdumontnu]

I think this issue is pretty out of date and should be closed.

There are still some things that need to be explained better in the UI (see discussion here). Specifically:

• "reviews from anyone with write access" -> "reviews from anyone with code write access" (unless that logic is changed in Bug fix allow users with access to count as official reviewers #31886)
• "Allow only to merge pull request with enough positive reviews from reviewers with code write access."

Here is what the page currently looks like: