feat: support --private-key with a PKCS#8 keypair #2653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By delegating to the existing `certcrypto.ParsePEMPrivateKey` impl, we can additionally support user-generated keypairs that are PKCS#8 encoded (vs just SEC1 for ECDSA or PKCS#1 for RSA). For example, `openssl genpkey` will use this format.
phlip9
changed the title
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By delegating to the existing
certcrypto.ParsePEMPrivateKeyimpl, we can additionally support user-generated keypairs that are PKCS#8 encoded (vs today only SEC1 for ECDSA or PKCS#1 for RSA). For example,openssl genpkeywill use this format. PKCS#8 PEM blocks use-----BEGIN PRIVATE KEY-----instead of-----BEGIN EC PRIVATE KEY-----or-----BEGIN RSA PRIVATE KEY-----.I tested this out manually, renewing an existing cert with a SEC1 keypair and generating a new one with an openssl-generate PKCS#8 keypair:
Another location (generating a .pfx file) also tried to manually parse PEM private keys, so I took the liberty of switching that over to
certcrypto.ParsePEMPrivateKeyas well.