Add DNS provider for Hostinger #2651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/dnsprovider
waiting-for/user-tests
|
I will latest test tomorrow, there was a domain forward with my test domain. It timed out on |
$ HOSTINGER_API_TOKEN="xxx" \
./dist/lego --email [email protected] --dns hostinger -d '*.my-domain.de' -d my-domain.de -s https://acme-staging-v02.api.letsencrypt.org/directory run
2025/09/22 09:25:25 No key found for account [email protected]. Generating a P256 key.
2025/09/22 09:25:25 Saved key to /Users/thomas/Code/lego/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2025/09/22 09:25:27 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.5-February-24-2025.pdf
Do you accept the TOS? Y/n
y
2025/09/22 09:25:31 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!
Your account credentials have been saved in your
configuration directory at "/Users/thomas/Code/lego/.lego/accounts".
You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from the ACME server so making regular
backups of this folder is ideal.
2025/09/22 09:25:31 [INFO] [*.my-domain.de, my-domain.de] acme: Obtaining bundled SAN certificate
2025/09/22 09:25:32 [INFO] [*.my-domain.de] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/229784594/19427347394
2025/09/22 09:25:32 [INFO] [my-domain.de] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/229784594/19427347404
2025/09/22 09:25:32 [INFO] [*.my-domain.de] acme: use dns-01 solver
2025/09/22 09:25:32 [INFO] [my-domain.de] acme: Could not find solver for: tls-alpn-01
2025/09/22 09:25:32 [INFO] [my-domain.de] acme: Could not find solver for: http-01
2025/09/22 09:25:32 [INFO] [my-domain.de] acme: use dns-01 solver
2025/09/22 09:25:32 [INFO] [*.my-domain.de] acme: Preparing to solve DNS-01
2025/09/22 09:25:55 [INFO] [my-domain.de] acme: Preparing to solve DNS-01
2025/09/22 09:26:07 [INFO] [*.my-domain.de] acme: Trying to solve DNS-01
2025/09/22 09:26:17 [INFO] [*.my-domain.de] acme: Checking DNS record propagation. [nameservers=10.0.0.10:53,[fded:38c5:4ff:0:e208:55ff:fe94:9390]:53,[2a01:41e3:274a:fa00:e208:55ff:fe94:9390]:53,[2a01:41e3:27a9:c700:e208:55ff:fe94:9390]:53]
2025/09/22 09:26:19 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2025/09/22 09:26:29 [INFO] [*.my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:26:41 [INFO] [*.my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:26:53 [INFO] [*.my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:27:05 [INFO] [*.my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:27:17 [INFO] [*.my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:27:19 [INFO] [my-domain.de] acme: Trying to solve DNS-01
2025/09/22 09:27:30 [INFO] [my-domain.de] acme: Checking DNS record propagation. [nameservers=10.0.0.10:53,[fded:38c5:4ff:0:e208:55ff:fe94:9390]:53,[2a01:41e3:274a:fa00:e208:55ff:fe94:9390]:53,[2a01:41e3:27a9:c700:e208:55ff:fe94:9390]:53]
2025/09/22 09:27:32 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2025/09/22 09:27:42 [INFO] [my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:27:54 [INFO] [my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:28:06 [INFO] [my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:28:18 [INFO] [my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:28:30 [INFO] [my-domain.de] acme: Waiting for DNS record propagation.
2025/09/22 09:28:32 [INFO] [*.my-domain.de] acme: Cleaning DNS-01 challenge
2025/09/22 09:28:44 [INFO] [my-domain.de] acme: Cleaning DNS-01 challenge
2025/09/22 09:28:57 [INFO] Deactivating auth: https://acme-staging-v02.api.letsencrypt.org/acme/authz/229784594/19427347394
2025/09/22 09:28:57 [INFO] Deactivating auth: https://acme-staging-v02.api.letsencrypt.org/acme/authz/229784594/19427347404
2025/09/22 09:28:58 Could not obtain certificates:
error: one or more domains had a problem:
[*.my-domain.de] propagation: time limit exceeded: last error: authoritative nameservers: NS ns1.dns-parking.com.:53 returned NXDOMAIN for _acme-challenge.my-domain.de.
[my-domain.de] propagation: time limit exceeded: last error: authoritative nameservers: NS ns2.dns-parking.com.:53 returned NXDOMAIN for _acme-challenge.my-domain.de.is there any way I can further debug this @ldez ? |
|
It looks like no TXT record is added during propagation |
|
Running curl https://developers.hostinger.com/api/dns/v1/zones/my-domain.de \
--request PUT \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer xxx' \
--data '{
"zone": [
{
"name": "_acme-challenge",
"records": [
{
"content": "aaa"
},
{
"content": "ADw2sEd82DUgXcQ9hNBZThJs7zVJkR5v9JeSbAb9mZY"
}
],
"ttl": 14400,
"type": "TXT"
}
]
}'manually works. dig +short TXT _acme-challenge.my-domain.de @ns1.dns-parking.com
"aaa"
"ADw2sEd82DUgXcQ9hNBZThJs7zVJkR5v9JeSbAb9mZY"The Hostinger API does |
|
This patch for diff --git a/providers/dns/hostinger/hostinger.go b/providers/dns/hostinger/hostinger.go
index abb91408..8505ea00 100644
--- a/providers/dns/hostinger/hostinger.go
+++ b/providers/dns/hostinger/hostinger.go
@@ -103,28 +103,59 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
ctx := context.Background()
- recordSets, err := d.client.GetDNSRecords(ctx, dns01.UnFqdn(authZone))
+ zoneName := dns01.UnFqdn(authZone)
+
+ recordSets, err := d.client.GetDNSRecords(ctx, zoneName)
if err != nil {
return fmt.Errorf("hostinger: get DNS records: %w", err)
}
- var newRecordSet []internal.RecordSet
+ hasTXTAtName := false
+ newRecordSets := make([]internal.RecordSet, 0, len(recordSets)+1)
- for _, recordSet := range recordSets {
- if recordSet.Name == subDomain && recordSet.Type == "TXT" {
- recordSet.Records = append(recordSet.Records, internal.Record{Content: info.Value})
+ containsValue := func(recs []internal.Record, val string) bool {
+ for _, r := range recs {
+ if r.Content == val {
+ return true
+ }
}
+ return false
+ }
- newRecordSet = append(newRecordSet, recordSet)
+ for _, rs := range recordSets {
+ // If this is the TXT set for _acme-challenge, merge the new value
+ if rs.Name == subDomain && rs.Type == "TXT" {
+ hasTXTAtName = true
+ if !containsValue(rs.Records, info.Value) {
+ rs.Records = append(rs.Records, internal.Record{Content: info.Value})
+ }
+ newRecordSets = append(newRecordSets, rs)
+ continue
+ }
+ // Keep every other record set as-is
+ newRecordSets = append(newRecordSets, rs)
}
- request := internal.ZoneRequest{
- Overwrite: false,
- Zone: newRecordSet,
+ // If no TXT record set exists yet for this name, create it
+ if !hasTXTAtName {
+ newRecordSets = append(newRecordSets, internal.RecordSet{
+ Name: subDomain, // should be "_acme-challenge"
+ Type: "TXT",
+ TTL: 300, // FIXME use env var
+ Records: []internal.Record{
+ {Content: info.Value},
+ },
+ })
}
- err = d.client.UpdateDNSRecords(ctx, dns01.UnFqdn(authZone), request)
- if err != nil {
+ req := internal.ZoneRequest{
+ Overwrite: false,
+ Zone: newRecordSets,
+ }
+
+ if err := d.client.UpdateDNSRecords(ctx, zoneName, req); err != nil {
return fmt.Errorf("hostinger: update DNS records (add): %w", err)
}Feel free to cherry pick as source of motivation. Sorry for my poor golang.
TL;DR: success + I'm no golang dev :D |
|
Your patch is not related to propagation, so I think you have wrongly interpreted the error. |
|
Can you only increase the propagation timeout |
|
OK, your explanation was not clear, but I think I understand: the TXT record was not created when there is no existing record set for the subdomain. Can you run my code and give me the log? |
|
aeb1017 fixed it, thanks! |
|
I need the logs. |
Here are the logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod tidyCloses #2650
Related to #2622
Ping @tafaust, can you run the command (with your domain, email, credentials, etc.)?
How to test this PR?
git clone https://github.com/ldez/lego.git cd lego git checkout feat/dns/hostingermake:make buildmake:go build -o dist/lego ./cmd/lego