Skip to content

fix: enforce HTTPS to the ACME server #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

fix: enforce HTTPS to the ACME server #2608

merged 2 commits into from
Aug 1, 2025

Conversation

@ldez
Copy link
Member

@ldez ldez commented Aug 1, 2025

@ldez ldez added this to the unreleased milestone Aug 1, 2025
@ldez ldez requested a review from dmke August 1, 2025 13:21
dmke
dmke approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should add a test to check whether using an HTTP URL would actually cause a failure.

@ldez ldez merged commit 238454b into go-acme:master Aug 1, 2025
7 checks passed
@ldez ldez deleted the fix/enforce-https branch August 1, 2025 14:35
@ldez ldez modified the milestones: unreleased, v4.25 Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmke dmke dmke approved these changes

Assignees

No one assigned

Labels

area/cli area/lib bug

Milestone

v4.25

Development

Successfully merging this pull request may close these issues.

2 participants

@ldez @dmke