vinyldns: add an option to add quotes around the TXT record value #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
|
Use the Route53 provider instead of the Vinyl one. Maybe I'm missing something? |
|
Hi, @ldez ! |
|
I found nothing in the API documentation about quotes around the TXT value.
I have no proof that it will not break the other users of Vinyl DNS. |
ldez
force-pushed
the
fix/vinyldns-route53
branch
from
b279d6e to
5f83f39
Compare
|
I added an option to add quotes ( The default behavior is unchanged, so no possible regressions. |
ldez
changed the title
|
Perfect, my friend. :) |
ldez
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds quotes to DNS records to ensure Route53 compatibility during the DNS-01 ACME/Let's Encrypt validation process.
Problem
The current code didn't include quotes in DNS record values, causing DNS-01 challenge failures when used with Route53. Route53 has specific formatting requirements that require certain values to be quoted.