Skip to content

Conversation

@marcusgrando
Copy link
Contributor

@marcusgrando marcusgrando commented Jul 7, 2025

also add tests.

@marcusgrando
Copy link
Contributor Author

@ldez I would appreciate it if you could look at this. 😉

@ldez ldez changed the title azion: add parent zone lookup support in Azion DNS provider azion: add parent zone lookup Jul 7, 2025
@ldez ldez self-requested a review July 7, 2025 14:40
@marcusgrando marcusgrando changed the title azion: add parent zone lookup azion: add parent zone lookup support Jul 7, 2025
@marcusgrando marcusgrando changed the title azion: add parent zone lookup support azion: add parent zone lookup Jul 7, 2025
@ldez
Copy link
Member

ldez commented Jul 7, 2025

@marcusgrando I have some doubts, based on your API documentation:
https://api.azion.com/#ba265bc9-82a9-4ec9-b5ca-2199a1ea0f40

{
  "count": 1,
  "links": {
    "previous": null,
    "next": null
  },
  "total_pages": 1,
  "results": [
    {
      "domain": "youdomain.com",
      "is_active": true,
      "name": "New Hosted Zone via API POST method",
      "id": 1234
    }
  ],
  "schema_version": 3
}

The field name is a random string, and the field domain is the domain.

Can you confirm that?

@ldez ldez added the bug label Jul 7, 2025
@ldez ldez added this to the unreleased milestone Jul 7, 2025
@ldez ldez changed the title azion: add parent zone lookup azion: improve zone lookup Jul 7, 2025
@marcusgrando
Copy link
Contributor Author

marcusgrando commented Jul 7, 2025

Yes, you are right. A name is just any given name that describes the domain, and the domain is exactly the FQDN.

@ldez
Copy link
Member

ldez commented Jul 7, 2025

ok so the existing implementation was wrong. I fixed that.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 17c65de into go-acme:master Jul 7, 2025
7 checks passed
@ldez ldez modified the milestones: unreleased, v4.24 Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants