-
-
Couldn't load subscription status.
- Fork 1.1k
azion: improve zone lookup #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ldez I would appreciate it if you could look at this. 😉 |
|
@marcusgrando I have some doubts, based on your API documentation: {
"count": 1,
"links": {
"previous": null,
"next": null
},
"total_pages": 1,
"results": [
{
"domain": "youdomain.com",
"is_active": true,
"name": "New Hosted Zone via API POST method",
"id": 1234
}
],
"schema_version": 3
}The field Can you confirm that? |
|
Yes, you are right. A name is just any given name that describes the domain, and the domain is exactly the FQDN. |
|
ok so the existing implementation was wrong. I fixed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
also add tests.