-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add DNS provider for DynDnsFree.de #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, in order for a PR adding a DNS provider to be accepted, you have to:
make test
make test
make generate-dns
rm -rf .lego
./lego -m [email protected] --dns YOUR_PROVIDER_NAME -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory runNote the wildcard domain is important.
make checks
|
|
Just some notes:
So either it was a bad copy-paste with no attempt to compile or run and no test execution, or it was AI-generated code. |
|
It was no AI slop that's for sure. It was an attempt to just get it working. I looked down how the active24 client was implemented but was unsure where to go from there and just called the URL with the parameters i had at hand. The program did compile at first but I committed to a later point which had some cruft left in. Sorry. Thank you for the clean up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Adds a DNS provider for DynDnsFree.de