Skip to content

Conversation

@ldez
Copy link
Member

@ldez ldez commented Mar 9, 2025

Fixes #2474

related to ietf-wg-acme/acme-ari#56

@ldez ldez added bug area/ari ACME Renewal Information Extension labels Mar 9, 2025
@ldez ldez added this to the unreleased milestone Mar 9, 2025
@ldez ldez requested a review from dmke March 9, 2025 15:43
@ldez
Copy link
Member Author

ldez commented Mar 9, 2025

I have a problem: the RFC is talking about alreadyReplaced type

But Boulder has no reference of that: alreadyReplaced

letsencrypt/boulder#7385

And Pebble has also no reference: Conflict

Also, the type inside the issue is urn:ietf:params:acme:error:conflict and not urn:ietf:params:acme:error:alreadyReplaced.

So I don't know if I should follow the RFC.

@dmke WDYT?

@ldez
Copy link
Member Author

ldez commented Mar 9, 2025

Maybe @beautifulentropy could help us in this context?

@dmke
Copy link
Member

dmke commented Mar 9, 2025

Hm. I need to think about that a bit.

My gut feeling says go with the standard (even though it's still a draft).

@beautifulentropy
Copy link
Contributor

beautifulentropy commented Mar 10, 2025

@dmke @ldez Thanks for bringing this to my attention. It appears that we've dropped the ball here, I'll see about getting a PR out to fix this issue in Boulder and ensure that we reference this PR.

@beautifulentropy
Copy link
Contributor

The aforementioned PR has been merged and should go to production next week. Thanks again for letting us know!

@ldez
Copy link
Member Author

ldez commented Mar 12, 2025

Thank you!
We will merge the PR, now we know we should follow the RFC.

@ldez ldez merged commit a8693c1 into go-acme:master Mar 12, 2025
7 checks passed
@ldez ldez deleted the fix/ari-alreadyReplaced branch March 12, 2025 19:31
@ldez ldez modified the milestones: unreleased, v4.23 Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ari ACME Renewal Information Extension bug

Development

Successfully merging this pull request may close these issues.

cannot indicate an order replaces certificate with serial <serial>, which already has a replacement order

3 participants