fix: kill hook when the command is stuck #2469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
context.WithTimeoutdoesn't kill a command when the command is stuck becauseCombinedOutputis waiting for a "pause".The previous implementation was able to stop the hook if the script was too long, but not stuck on one element (cf test:
sleepy.sh).But it was not able to stop the hook if the script was waiting for a long (never-ending) process (cf test:
sleeping_beauty.sh).I modified the code to add a timer that kills the current process if the timeout is reached.
This implementation has another advantage: the output of the hook will be live streamed to the console.
Fixes #2468