Skip to content

acme-dns: continue the process when the CNAME is handled by the storage #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025
Merged

acme-dns: continue the process when the CNAME is handled by the storage #2443

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
255139e
acme-dns: fix present
ldez Feb 17, 2025
1800a01
acme-dns: fix present
ldez Feb 17, 2025
ce02f59
chore: simplify
ldez Feb 17, 2025
54f4a22
chore: simplify
ldez Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions providers/dns/acmedns/acmedns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,13 @@ func (d *DNSProvider) Present(domain, _, keyAuth string) error {

// Check if credentials were previously saved for this domain.
account, err := d.storage.Fetch(ctx, domain)
if err != nil {
if err != nil && !errors.Is(err, internal.ErrCNAMEAlreadyCreated) {
if errors.Is(err, storage.ErrDomainNotFound) {
// The account did not exist.
// Create a new one and return an error indicating the required one-time manual CNAME setup.
return d.register(ctx, domain, info.FQDN)
}

// Errors other than goacmedns.ErrDomainNotFound are unexpected.
return err
}

Expand Down Expand Up @@ -221,7 +220,7 @@ func (d *DNSProvider) register(ctx context.Context, domain, fqdn string) error {
}

if cnameCreated {
return nil
return internal.ErrCNAMEAlreadyCreated
}

// Stop issuance by returning an error.
Expand Down