-
-
Couldn't load subscription status.
- Fork 1.1k
Add DNS provider for F5 XC #2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The wrong usage of HTTP code is a problem: technically, a retry should only be done on client errors (4xx) and never on server errors (5xx). And without the documentation about the field |
This comment was marked as outdated.
This comment was marked as outdated.
|
I implemented a naive retry, this should help. |
|
Thanks, that works great. There is one minor error that does popup when trying to clean up the TXT records but the actual records seem to be cleaned up. |
|
the cleanup error is expected because I remove the full RRSet related to ACME challenge in one time, so you can ignore it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
go mod tidyPing @Ewouddlb, can you run the command (with your domain, email, credentials, etc.)?
Closes #2408
How to test this PR?
git clone https://github.com/ldez/lego.git cd lego git checkout feat/f5xcmake:make buildmake:go build -o dist/lego ./cmd/lego