Skip to content

Conversation

@deining
Copy link
Contributor

@deining deining commented Aug 18, 2023

This PR changes: the way the documentation is created: hugo-theme-learn ist now pulled in as hugo module. This is the newer and more elegant way to use hugo theme components.

@ldez
Copy link
Member

ldez commented Aug 18, 2023

Hello,

it was a choice to not use the hugo module system, when I added the theme the hugo module system was already existing.

@ldez ldez self-requested a review August 18, 2023 11:29
@deining
Copy link
Contributor Author

deining commented Aug 18, 2023

Hello,

it was a choice to not use the hugo module system, when I added the theme the hugo module system was already existing.

I see. I respect your decision.
Out of interest: may I ask why you deliberately didn't use the hugo module system?

@ldez
Copy link
Member

ldez commented Aug 18, 2023

Even if I really appreciate Hugo, I encounter several problems.
The zerover approach is a problem.
I was a long-time user and at some point, I was tired of breaking changes and the choice of standard or extended version.
This PR is a good example: https://github.com/go-acme/lego/actions/runs/5901899017/job/16011104875?pr=1994

The hugo module system is pretty much the same thing.
The git submodule was a bad solution for me, and I never use it.
When the hugo modules appear I was thinking that was a solution but I "fought" against themes that have some Go files in them.
At this time, the Go modules were new, and hugo modules too.
It was not a good experience so I decided to use a simple git clone.

But maybe it's time to evaluate again the hugo modules.


I have a question completely off-topic: you feel like a "Hugo evangelist", and I need to replace the way to build the documentation for another opensource project (but I need to keep the style and several other things), are you interested to help me on that?

@ldez ldez changed the title documentation: Retrieve hugo-theme-learn as hugo module doc: retrieve hugo-theme-learn as hugo module Aug 18, 2023
@deining
Copy link
Contributor Author

deining commented Aug 18, 2023

I have a question completely off-topic: you feel like a "Hugo evangelist",

I wouldn't say that. I use hugo for documentation purposes and like it, but I clearly see the deficencies (as you!).

and I need to replace the way to build the documentation for another opensource project (but I need to keep the style and several other things), are you interested to help me on that?

I need to know a bit more background to give an answer here. Feel free to write me privately (see my GitHub profile) and tell me a bit more about your project, your needs and your plans.

@ldez
Copy link
Member

ldez commented Aug 18, 2023

There is nothing private 😄, it is just a question to know if it's something possible.
I need to talk with the maintainers of this project before.

@deining deining force-pushed the hugo-theme-learn-as-module branch 2 times, most recently from 8e01d1f to 7eb799b Compare August 19, 2023 07:13
@deining
Copy link
Contributor Author

deining commented Aug 19, 2023

There is nothing private 😄, it is just a question to know if it's something possible.

Yes it is. No promise, though.

I need to talk with the maintainers of this project before.

Keep me informed.

@deining
Copy link
Contributor Author

deining commented Aug 19, 2023

But maybe it's time to evaluate again the hugo modules.

After bumping to latest hugo version, checkers are green now 😄.

@deining deining force-pushed the hugo-theme-learn-as-module branch 3 times, most recently from 066a7a4 to de74312 Compare August 19, 2023 16:08
@deining deining requested a review from ldez August 19, 2023 16:08
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the hugo-theme-learn-as-module branch from de74312 to 9c7264a Compare August 19, 2023 18:38
@ldez ldez enabled auto-merge (squash) August 19, 2023 18:38
@ldez ldez added this to the v4.14 milestone Aug 19, 2023
@ldez ldez merged commit 406dad3 into go-acme:master Aug 19, 2023
@deining deining deleted the hugo-theme-learn-as-module branch August 19, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants