Skip to content

chore: fix grammar and typo #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2023
Merged

chore: fix grammar and typo #1978

merged 3 commits into from
Jul 29, 2023

Conversation

@ldez
Copy link
Member

@ldez ldez commented Jul 28, 2023

No description provided.

@ldez ldez added this to the v4.14 milestone Jul 28, 2023
@ldez ldez requested a review from dmke July 28, 2023 13:57
dmke
dmke reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm half-way through, but something important came up; will continue later.)

dmke
dmke requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two remarks though.

@ldez ldez merged commit 3cefc7a into go-acme:master Jul 29, 2023
@ldez ldez deleted the fix/grammar branch July 29, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmke dmke dmke approved these changes

Assignees

No one assigned

Labels

area/documentation bug

Milestone

v4.14

Development

Successfully merging this pull request may close these issues.

2 participants

@ldez @dmke