Parse namespaces as single tokens #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 2, 2022 13:43
…NAME_FULLY_QUALIFIED. This considers an entire namespace path (e.g. `\Foo\Bar` or `namespace\Baz` as a single token.
This path handled top statements such as: ```php namespace\foo(); ``` This would end up in `read_namespace` due to the `T_NAMESPACE` token. However, with the changes in the previous two commits this is now parsed as a single `T_NAME_RELATIVE` token, and is parsed as a regular call expression statement instead.
…able. I ran into issues when enabling debug mode, that unclosed nodes from one test (sometimes on purpose), caused unclosed nodes errors on other tests. By tracking the AST stack on `this` rather than on the `AST` class directly, this can no longer happen, and each test runs in isolation.
Collaborator
|
Hi @MaartenStaa - thanks for this awesome contribution and sorry about the delay with the review. I hope I'll get to it on the weekend! |
Collaborator
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in PHP itself, introduce the tokens
T_NAME_RELATIVE,T_NAME_QUALIFIED, andT_NAME_FULLY_QUALIFIED.Fixes #834.
Fixes #896.