Skip to content

fix double key input on windows due to crossterm 0.26 #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2023
Merged

fix double key input on windows due to crossterm 0.26 #1686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::notify_mutex::NotifyableMutex;
use anyhow::Result;
use crossbeam_channel::{unbounded, Receiver, Sender};
use crossterm::event::{self, Event};
use crossterm::event::{self, Event, Event::Key, KeyEventKind};
use std::{
sync::{
atomic::{AtomicBool, Ordering},
Expand Down Expand Up @@ -113,6 +113,12 @@ impl Input {
arc_current.store(true, Ordering::Relaxed);

if let Some(e) = Self::poll(POLL_DURATION)? {
// windows send key release too, only process key press
if let Key(key) = e {
if key.kind != KeyEventKind::Press {
continue;
}
}
tx.send(InputEvent::Input(e))?;
}
} else {
Expand Down