Skip to content

Conversation

@SergioRibera
Copy link
Contributor

This PR is to add the rust-toolchain file that allows all those who want to contribute or run the project to do it under the same version of Rust

Inspiration

When I did my PR, I did it working under the version of rust that I use in my day to day (a nightly version), which caused confusions and problems when incorporating the changes, I have also seen something similar happen in the PR of clippy fixes, so I think it is necessary to be able to work together in a safe and orderly way.

This Pull Request not fixes/closes any

It changes the following:

  • Add rust-toolchain file

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog (For this change is it required?)

@extrawurst
Copy link
Collaborator

I am always using latest stable, is that something we can define in the file?

@SergioRibera
Copy link
Contributor Author

SergioRibera commented Oct 20, 2022

I am always using latest stable, is that something we can define in the file?

Yep, you can see that in the file there is a part that says

#...
channel = "1.60.0"
#...

We can put stable if you prefer so that it always uses the most recent stable version

You can see more details in the link to rust's book

@extrawurst
Copy link
Collaborator

ok please make it track "stable" like the CI does too

@extrawurst extrawurst merged commit c7e54fa into gitui-org:master Oct 20, 2022
@extrawurst
Copy link
Collaborator

Thank you!

@SergioRibera SergioRibera deleted the standar_rust_version branch October 20, 2022 14:39
@extrawurst
Copy link
Collaborator

damn it seems to fuck up the CI and overwrite the compiler version chosen in there. so I have to roll it back

extrawurst added a commit that referenced this pull request Oct 20, 2022
@extrawurst
Copy link
Collaborator

see d92d43a

@SergioRibera SergioRibera restored the standar_rust_version branch October 20, 2022 14:56
@SergioRibera
Copy link
Contributor Author

SergioRibera commented Oct 20, 2022

damn it seems to fuck up the CI and overwrite the compiler version chosen in there. so I have to roll it back

Mmmmm, let's open the PR again then, now tell me, don't you think this is good? so we can define in this file the version of Rust that will be used everywhere? If not, then how about defining the channel with the version used in the CI?

On the other hand I am reading the CI logs and I don't see any problem, would you be so kind to explain it to me please?

@extrawurst
Copy link
Collaborator

extrawurst commented Oct 20, 2022

Here is the CI after I merged your change: https://github.com/extrawurst/gitui/actions/runs/3290393076

Here is the run after I reverted your change:
https://github.com/extrawurst/gitui/actions/runs/3290616619

It breaks on linux-musl builds.

Unfortunately I did not run CI on your change first. my mistake.

Feel free to reopen and fix.

@SergioRibera
Copy link
Contributor Author

Here is the CI after I merged your change: https://github.com/extrawurst/gitui/actions/runs/3290393076

Here is the run after I reverted your change: https://github.com/extrawurst/gitui/actions/runs/3290616619

It breaks on linux-musl builds.

Oooooh, great, I see what happened, yep, I can fix it, give me a moment and I'll open the PR again.

SergioRibera added a commit to SergioRibera/gitui that referenced this pull request Oct 21, 2022
* Generate rust toolchain file
* Make track "stable" channel
SergioRibera pushed a commit to SergioRibera/gitui that referenced this pull request Oct 21, 2022
heiskane pushed a commit to heiskane/gitui that referenced this pull request Oct 22, 2022
heiskane pushed a commit to heiskane/gitui that referenced this pull request Feb 11, 2023
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* Generate rust toolchain file
* Make track "stable" channel
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants