-
-
Notifications
You must be signed in to change notification settings - Fork 670
Generate rust toolchain file - to develop (and build) #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate rust toolchain file - to develop (and build) #1397
Conversation
|
I am always using latest stable, is that something we can define in the file? |
Yep, you can see that in the file there is a part that says #...
channel = "1.60.0"
#...We can put You can see more details in the link to rust's book |
|
ok please make it track "stable" like the CI does too |
|
Thank you! |
|
damn it seems to fuck up the CI and overwrite the compiler version chosen in there. so I have to roll it back |
This reverts commit c7e54fa.
|
see d92d43a |
Mmmmm, let's open the PR again then, now tell me, don't you think this is good? so we can define in this file the version of Rust that will be used everywhere? If not, then how about defining the On the other hand I am reading the CI logs and I don't see any problem, would you be so kind to explain it to me please? |
|
Here is the CI after I merged your change: https://github.com/extrawurst/gitui/actions/runs/3290393076 Here is the run after I reverted your change: It breaks on linux-musl builds. Unfortunately I did not run CI on your change first. my mistake. Feel free to reopen and fix. |
Oooooh, great, I see what happened, yep, I can fix it, give me a moment and I'll open the PR again. |
* Generate rust toolchain file * Make track "stable" channel
* Generate rust toolchain file * Make track "stable" channel
This PR is to add the rust-toolchain file that allows all those who want to contribute or run the project to do it under the same version of Rust
Inspiration
When I did my PR, I did it working under the version of rust that I use in my day to day (a nightly version), which caused confusions and problems when incorporating the changes, I have also seen something similar happen in the PR of clippy fixes, so I think it is necessary to be able to work together in a safe and orderly way.
This Pull Request not fixes/closes any
It changes the following:
I followed the checklist:
make checkwithout errors