Skip to content

analyze table before cutover #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

analyze table before cutover #1419

wants to merge 2 commits into from

Conversation

wangzihuacool
Copy link
Contributor

Related issue: #1418

Description:
analyze ghost table before cutover to avoid table statistics not timely updated.

@meiji163
Copy link
Contributor

LGTM

@shaohk
Copy link
Contributor

shaohk commented May 30, 2024

When the modified table is a partition table, the execution time of the ANALYZE command will increase as the number of partitions increases. When the ANALYZE statement is synchronized to the replica, it may cause replication lag.

@meiji163
Copy link
Contributor

When the ANALYZE statement is synchronized to the replica, it may cause replication lag.

Maybe make this feature a optional flag then? What do you think @timvaillancourt ?

timvaillancourt
timvaillancourt approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timvaillancourt
Copy link
Collaborator

When the modified table is a partition table, the execution time of the ANALYZE command will increase as the number of partitions increases. When the ANALYZE statement is synchronized to the replica, it may cause replication lag.

@meiji163 considering this (I didn't think of it) I suggest this is an optional flag for now and we can have opt-in users report on performance

@wangzihuacool can you add an optional flag and doc/command-line-flags.md update for this one?

@timvaillancourt timvaillancourt self-requested a review August 15, 2024 22:29
@Zorgon66

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiji163 meiji163 meiji163 approved these changes

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

Assignees
No one assigned
Labels
enhancement high-risk needs-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangzihuacool @meiji163 @shaohk @timvaillancourt @Zorgon66