fix: docker image content #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A .dockerignore file is added to exclude non-application files and test files from the Docker build context.
- Add patterns to ignore Python bytecode, logs, IDE settings, dependency directories, and test files.
- Exclude common workspace and Git metadata from image builds.
- [x] add .dockerignore to ensure non application files/test files don't get into the container image Tested locally with the following commands: ```bash ➜ docker build . --tag test:1 ➜ docker run -it --rm --name debug --entrypoint /bin/bash test:1 ## inside container root@3624b051f2c8:/action/workspace# ls -lah total 44K drwxr-xr-x 1 root root 4.0K May 27 13:11 . drwxr-xr-x 1 root root 4.0K May 27 13:11 .. -rw-r--r-- 1 root root 1.8K Jan 7 10:26 auth.py -rw-r--r-- 1 root root 4.4K Mar 30 23:25 env.py -rw-r--r-- 1 root root 68 Apr 4 04:04 requirements.txt -rwxr-xr-x 1 root root 14K May 27 12:11 stale_repos.py ``` Signed-off-by: jmeridth <[email protected]>
zkoppert
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally with the following commands:
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
bug,documentation,enhancement,infrastructure,maintenanceorbreaking