Remove link to blog #2807
Merged
Remove link to blog #2807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The change LGTM 👍 As far as I can see, all of our recent changes have been made on |
jf205
approved these changes
Feb 11, 2020
Contributor
|
#2809 👈 needs to be merged before we update help.semmle.com please! |
Contributor
|
@jf205 - does this mean that we are republishing the learning QL material for the 1.23.1 release? If that's the case, we'll need to update the check list to put them back. |
Contributor
|
As discussed on Slack, this isn't related to 1.23.1, the timing just coincides. We'll update the live content when we're ready. |
Contributor
Author
|
Sorry, didn't mean to raise any alarm bells about republishing! Thanks for checking 👀 |
Contributor
|
Np @shati-patel - I was conflating the two things... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst looking at @felicitymay's PR to update the help.semmle.com footer, I remembered that we still link to the Semmle blog from certain Sphinx projects like Learning CodeQL too.
Not that it really matters, but the Sphinx stuff is likely to be around for a while before we migrate, so it's probably worth updating. (Non-urgent of course. I've used
rc/1.23to match the other PR, but we don't need to republish this immediately.)@jf205 - could you review please?