C#: Fix a database inconsistency caused by qualifiable delegate invocations #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumgrant
added
depends on internal PR
calumgrant
force-pushed
the
cs/qualifiable-delegates
branch
2 times, most recently
from
bad8ef7 to
290e8ad
Compare
hvitved
requested changes
Feb 12, 2020
| | @method_invocation_expr | ||
| | @element_access_expr; | ||
| | @element_access_expr | ||
| | @delegate_invocation_expr; |
There was a problem hiding this comment.
I guess we should add QualifiableExpr as a base class of DelegateCall too then? Even though it may look like an innocent change, simple changes to the type hierarchy have caused performance problems in the past, so we better run a dist comparison.
calumgrant
force-pushed
the
cs/qualifiable-delegates
branch
from
9492fc5 to
a829951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a
VALUE_NOT_IN_TYPEcaused byNote: will need a DB scheme bump prior to merge.